Skip to content

Update garnetCache.json #38907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update garnetCache.json #38907

wants to merge 1 commit into from

Conversation

@mbhaskar
Copy link
Member

@mbhaskar mbhaskar commented Nov 20, 2025 •
edited
Loading

Changing entity names to resolve conflicts in sdk generation.

This PR is in response to a conflict generated due to ClusterResrouce entity name being used already but duplicated in garnetCache.json. Entity names are appended with Garnet to resolve conflicts

** Was added to a conversation with Azure Dev Exp and this seems to be blocking the TSP Migration

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@mbhaskar
Update garnetCache.json
27c0e20 
Changing entity names to resolve conflicts in sdk generation
@mbhaskar mbhaskar requested a review from pjohari-ms as a code owner November 20, 2025 20:51
@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DocumentDB-DocumentDB
Go sdk/resourcemanager/cosmos/armcosmos
Java com.azure.resourcemanager:azure-resourcemanager-cosmosdbdocumentdb
JavaScript @azure/arm-cosmosdb
Python azure-mgmt-cosmosdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjohari-ms pjohari-ms Awaiting requested review from pjohari-ms pjohari-ms is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ARMReview brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Cosmos resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mbhaskar